Skip to content

Remove commit SHA from the version pushed to Test PyPI #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ickerday merged 1 commit into from
May 8, 2026
+6 −10
Merged

Remove commit SHA from the version pushed to Test PyPI #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
# https://github.com/pypa/gh-action-pypi-publish/issues/217#issuecomment-1965727093
runs-on: ubuntu-latest
outputs:
version: ${{ steps.get-version.outputs.version }}
version: ${{ steps.set-version.outputs.version }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
with:
Expand All @@ -27,19 +27,16 @@ jobs:
run: |
VERSION_BASE="$(uv version --short)"
RUN_NUMBER="${{ github.run_number }}"
COMMIT_SHA="$(git rev-parse --short HEAD)"
uv version --frozen "${VERSION_BASE}.dev${RUN_NUMBER}+g${COMMIT_SHA}"
- name: Get current version
id: get-version
run: echo "version=$(uv version --short)" >> "$GITHUB_OUTPUT"
uv version --frozen "${VERSION_BASE}.dev${RUN_NUMBER}"
echo "version=$(uv version --short)" >> "$GITHUB_OUTPUT"
- name: Build packages for distribution
run: uv build
- name: Run AppInspect
uses: ./.github/actions/run-appinspect
- name: Upload distributables
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
with:
name: splunk-sdk-${{ steps.get-version.outputs.version }}
name: splunk-sdk-${{ steps.set-version.outputs.version }}-g${{ github.sha }}
path: dist/
- name: Generate API reference
run: make -C ./docs html
Expand All @@ -62,8 +59,7 @@ jobs:
- name: Download distributables
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c
with:
name: splunk-sdk-${{ needs.build-distributables.outputs.version }}
path: dist/
name: splunk-sdk-${{ needs.build-distributables.outputs.version }}-${{ github.sha}}
- name: Publish packages to Test PyPI
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b
with:
Expand All @@ -82,7 +78,7 @@ jobs:
- name: Download distributables
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c
with:
name: splunk-sdk-${{ needs.build-distributables.outputs.version }}
name: splunk-sdk-${{ needs.build-distributables.outputs.version }}-${{ github.sha}}
path: dist/
- name: Publish packages to PyPI
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b
Expand Down