Setting to have placed blocks open to the public by default#266
Merged
spnda merged 5 commits intospnda:masterfrom Feb 24, 2024
Merged
Setting to have placed blocks open to the public by default#266spnda merged 5 commits intospnda:masterfrom
spnda merged 5 commits intospnda:masterfrom
Conversation
TheDiscordian
changed the title
spnda
requested changes
Feb 16, 2024
Owner
spnda
left a comment
spnda
left a comment
There was a problem hiding this comment.
Adding the public as a default friend automatically should happen in a PlayerJoinEvent handler.
Add a new @EventHandler annotated function to listeners/JoinEventListener.java that checks if player.hasPlayedBefore() and then add the to the default friends.
TheDiscordian
force-pushed
the
PublicOnPlace
branch
from
6abfa16 to
d4958fa
Compare
Contributor
Author
|
@spnda I couldn't see how to setup a new function as there's already an |
spnda
approved these changes
Feb 24, 2024
spnda
added a commit
that referenced
this pull request
Jul 12, 2024
The PR changed the config key name at the end, but forgot to change the key name in the Java source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265.
Adds setting
public_on_place_by_default. Makes it so public is a friend by default.