chore: exclude landing from workspace while Void SDK is in private beta#105
Merged
doodlewind merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
The landing package depends on @void-sdk/* packages hosted on GitHub Packages, which are in closed beta. Contributors without a NODE_AUTH_TOKEN hit 403 on `pnpm install` at the repo root, blocking anyone cloning the repo from getting started. Temporary workaround until Void SDK is publicly available: - pnpm-workspace.yaml: exclude packages/landing so root install skips resolving its @void-sdk/* deps. - .npmrc: move from repo root into packages/landing so the token env lookup (and its WARN) only happens when installing landing directly. - deploy-landing.yml: drop the push trigger (landing deploys are paused anyway), keep workflow_dispatch, and run `pnpm install` + `pnpm deploy` inside packages/landing since it's no longer a filterable workspace member. - README: drop the "+ landing" note from `pnpm dev`. - pnpm-lock.yaml: regenerated — drops ~230 packages in the @void-sdk / @voidzero-dev subtree. Contributors with a GitHub Packages token can still `cd packages/landing && pnpm install` locally to work on the site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm installwas 403-ing for any contributor without aNODE_AUTH_TOKEN, becausepackages/landingdepends on@void-sdk/*packages hosted on GitHub Packages (currently closed beta).packages/landingfrom the pnpm workspace so the root install no longer resolves those private deps..npmrcintopackages/landing/— the token env lookup (and its WARN) now only happens when someone explicitly installs the landing package.on: pushremoved,workflow_dispatchkept); the job now installs insidepackages/landingdirectly since it's no longer a filterable workspace member.pnpm-lock.yamlregenerated — drops ~230 packages in the@void-sdk/@voidzero-devsubtree.Landing code is untouched. Anyone with a GitHub Packages token can still
cd packages/landing && pnpm installto work on the site locally, and the deploy workflow still works when triggered manually.Revert this once Void SDK is publicly available.
Test plan
pnpm installat repo root completes with no warnings and no 403pnpm-lock.yamlcontains zero@void-sdk/@voidzero-devreferencesworkflow_dispatchrun ofDeploy Landing Pageconfirms the landing deploy path still works🤖 Generated with Claude Code