Skip to content

chore(m5): cut connector UI from renderer (PR1 of 7)#112

Merged
graydawnc merged 3 commits intomainfrom
chore/m5-pr1-ui-cut
Apr 28, 2026
Merged

chore(m5): cut connector UI from renderer (PR1 of 7)#112
graydawnc merged 3 commits intomainfrom
chore/m5-pr1-ui-cut

Conversation

@graydawnc
Copy link
Copy Markdown
Collaborator

@graydawnc graydawnc commented Apr 28, 2026

Summary

First of 7 PRs implementing M5 — drop connector subsystem from Spool.

This PR removes the renderer / App surface area for connectors and captures. It is intentionally narrow:

  • Touched: only packages/app/src/renderer/ and one e2e spec
  • Not touched: core types, preload connectors namespace, main-process IPC handlers, core/connectors engine, DB schema, CLI

Captures still returned by existing IPC are filtered out at the App.tsx boundary (fragmentSources, fragmentPreview, fragmentScopedResults, session-only starredItems). Subsequent PRs will trim the data path itself.

Changes

  • SettingsPanel — Connectors tab renamed to Sources (layers icon); body trimmed to just the Agent Sessions section. General tab unchanged. Tab union becomes general | appearance | sources | agent.
  • HomeViewCaptureSuggestionRow, capture chips, and + Connect button removed
  • FragmentResults — narrowed to fragment-only; CaptureRow removed
  • StarredItems — narrowed to session-only; StarredCaptureRow removed
  • StarButton — simplified (always session); no kind prop
  • App.tsx — dropped captureSources / platformColors / starredCaptures / connectorToast state; dropped connector event listener, refreshCaptureSources, handleConnectClick; SettingsTab union updated
  • DeletedManualInstallModal.tsx, PackageSetupCard.tsx, SourcesPanel.tsx (last was already dead), unused PlatformBadge
  • e2e — dropped home-preview.spec.ts test that asserted captures appeared in the dropdown (it tests a removed UI behavior); kept helpers/seed.ts since it depends on main-side __spoolSeedCapture (will go in PR4)

-1490 / +106 net.

Test plan

  • pnpm exec tsc --noEmit clean (packages/app)
  • pnpm build:electron passes (core + connector-sdk + main + preload + renderer)
  • Smoke test: launch app, search sessions, star/unstar, open settings — verify all 4 tabs (General, Appearance, Sources, Agent)
  • Smoke test: confirm preload connectors API still resolves (handlers untouched), even though renderer no longer calls them

🤖 Generated with Claude Code

graydawnc and others added 3 commits April 28, 2026 15:47
PR1 of M5 (Spool Daemon split — Spool-side cleanup). Removes the
connector / capture surface from the renderer and App entry point,
without touching core types, preload, main process, or DB. Captures
returned by existing IPC are filtered out at the App boundary.

- SettingsPanel: drop Connectors tab; move Agent Sessions into General
- HomeView: drop CaptureSuggestionRow + capture chips + + Connect button
- FragmentResults: narrow to fragment-only; drop CaptureRow
- StarredItems: narrow to session-only; drop StarredCaptureRow
- StarButton: simplify (always session)
- App.tsx: drop captureSources/platformColors/starredCaptures state,
  connector event listener, refreshCaptureSources, handleConnectClick,
  connectorToast; filter results/preview/starred at the boundary
- Delete dead components: ManualInstallModal, PackageSetupCard,
  SourcesPanel; drop unused PlatformBadge

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The "home dropdown surfaces a capture" test asserts a UI behavior that
PR1 just removed (capture suggestions no longer render). Drop the test
+ its seedCapture beforeAll. helpers/seed.ts stays — referenced by
__spoolSeedCapture in main, will go in PR4.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reverts the GeneralTab folding from the previous PR1 commit. Connectors
tab is renamed to Sources (with a layers icon) and now hosts only the
Agent Sessions section. Leaves headroom for future source-import
features without crowding General.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant