feat: auto-detect terminal for session resume with settings override#26
Merged
feat: auto-detect terminal for session resume with settings override#26
Conversation
…ssion resume Previously, session resume always opened macOS Terminal.app via AppleScript. This change detects the user's preferred terminal automatically and adds a manual override in Settings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session resume previously always opened macOS Terminal.app. This PR adds:
How it works
Terminal detection (
packages/app/src/main/terminal.ts)open -a <app> --args)~/.warp/launch_configurations/and opens it viawarp://launch/URI scheme (Warp's official API, no Accessibility permissions needed)osascript -e 'application "X" is running'for each known third-party terminal, cached for the process lifetimeexistsSyncon/Applications/<app>.appprevents selecting a terminal that isn't installedSettings UI (
packages/app/src/renderer/components/SettingsPanel.tsx)~/.spool/agents.jsonasterminalfield inAgentsConfigselectAgent,selectTerminal,selectDefaultSearchSort) into a singleupdateConfigfunctionSession cwd (
packages/core/src/types.ts,packages/core/src/db/queries.ts)cwdfield toFragmentResult(fromsessions.cwdcolumn, notprojects.display_path)Files changed
packages/app/src/main/terminal.tsopenTerminal()packages/app/src/main/index.tsopenTerminal()with cwd and preferencepackages/app/src/main/acp.tsterminaltoAgentsConfigpackages/app/src/preload/index.tsterminalto config,cwdtoresumeCLIpackages/app/src/renderer/components/SettingsPanel.tsxpackages/app/src/renderer/components/ContinueActions.tsxresult.cwdtoresumeCLIpackages/core/src/types.tscwd?toFragmentResultpackages/core/src/db/queries.tssess.cwdto search queryTest plan
🤖 Generated with Claude Code