Skip to content

fix: resolve install.sh mount point before copying Spool.app#36

Merged
doodlewind merged 1 commit intospool-lab:mainfrom
chumyin:fix/install-script-mount-point
Apr 3, 2026
Merged

fix: resolve install.sh mount point before copying Spool.app#36
doodlewind merged 1 commit intospool-lab:mainfrom
chumyin:fix/install-script-mount-point

Conversation

@chumyin
Copy link
Copy Markdown
Contributor

@chumyin chumyin commented Apr 3, 2026

Summary

  • remove -quiet from hdiutil attach so the installer can parse the mounted volume path
  • fail early if the mount point cannot be resolved or if the mounted DMG does not contain Spool.app
  • keep the detach step quiet without depending on attach output suppression

Validation

  • ran bash -n packages/landing/public/install.sh
  • ran the patched installer with a temporary install directory and verified it copied Spool.app
  • verified the installed bundle reports com.linkclaw.spool and version 0.3.1

Closes #35

Copy link
Copy Markdown
Contributor

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@doodlewind doodlewind merged commit da2f70c into spool-lab:main Apr 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install.sh fails because hdiutil attach uses -quiet while parsing the mount point

2 participants