docs: add rfc to describe cluster proxy/agent#41
Merged
Conversation
ShookLyngs
requested changes
Jan 11, 2024
linnnsss
reviewed
Jan 11, 2024
Collaborator
linnnsss
left a comment
linnnsss
left a comment
There was a problem hiding this comment.
I recommend giving separate links/headings to each step and the associated methods, to enhance the overall structure with improved readability.
Flouse
suggested changes
Jan 11, 2024
ashuralyk
force-pushed
the
doc/proxy-agent-md
branch
4 times, most recently
from
62e753b to
f5b8243
Compare
ashuralyk
force-pushed
the
doc/proxy-agent-md
branch
from
f5b8243 to
2f8ccec
Compare
Contributor
Author
recommended changes have been applied, please review again |
Flouse
reviewed
Jan 13, 2024
| Data: REFERENCED_CLUSTER_ID | ||
| Type: | ||
| code_hash: CLUSTER_PROXY_TYPE_HASH | ||
| args: <cluster_proxy_id> [<min_payment>] |
Contributor
There was a problem hiding this comment.
As we discussed, will ClusterProxy's min_payment be moved to cell_data in this RPC version or next version?
Contributor
Author
There was a problem hiding this comment.
after I complete it, I'll change this doc description about min_payment
Flouse
approved these changes
Jan 13, 2024
improve language clarity
linnnsss
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Flouse @ShookLyngs @quake anything recommended to change can be posted here