Feature/Avoid deleting stored files when URL path is empty#6
Merged
khaptonstall merged 2 commits intomainfrom Nov 19, 2021
Merged
Feature/Avoid deleting stored files when URL path is empty#6khaptonstall merged 2 commits intomainfrom
khaptonstall merged 2 commits intomainfrom
Conversation
rhogan11
previously approved these changes
Nov 19, 2021
rhogan11
reviewed
Nov 19, 2021
| /// Deletes the store's .sqlite, .sqlite-shm, and .sqlite-wal files. | ||
| func deleteStoreFiles() throws { | ||
| guard let storeURLPath = self.url?.path else { | ||
| guard let storeURLPath = self.url?.path, !storeURLPath.isEmpty else { |
There was a problem hiding this comment.
wonder if there is any benefit to using file exists apis?
Contributor
Author
There was a problem hiding this comment.
Good call, I'll look at adjusting these checks!
Generated by 🚫 Danger |
rhogan11
approved these changes
Nov 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures the
storeURLPathis not an empty string before attempting to delete items, which avoid unnecessary thrown errors.