IOS-3084: Feature/Ensure thread safety#7
Merged
khaptonstall merged 2 commits intomainfrom Nov 29, 2021
Merged
Conversation
All methods will use the synchronous performAndWait, which coincides with their method signatures (i.e. they don't currently accept completion blocks).
lquigley
previously approved these changes
Nov 24, 2021
Generated by 🚫 Danger |
lquigley
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
https://spothero.atlassian.net/browse/IOS-3084
Description
Updated all methods which perform work on an
NSManagedObjectContextto ensure thread safety by using the MOC's thread to do the work (i.e. through theperformAndWait {}block).performAndWaitwas used over the asynchronousperformmethod to better match the existing method signatures (as none of them accept completion block arguments).Adding support for better control over which type of work is performed (synchronous vs asynchronous) and leveraging Swift Concurrency are captured in upcoming tickets.