This repository was archived by the owner on Jan 17, 2019. It is now read-only.
Notify header component of content offset change when it appears#65
Merged
JohnSundell merged 2 commits intospotify:masterfrom Oct 10, 2016
Merged
Conversation
This patch fixes a bug where header components wouldn’t be notified of a content offset change when they appear. Body & overlay components already had this intended behavior. The fix is to merge the “component will appear” logic into a single method, to make sure that all components are treated the same in this regard.
Contributor
Author
|
@spotify/objc-dev |
Current coverage is 94.27% (diff: 100%)@@ master #65 diff @@
==========================================
Files 57 57
Lines 3860 3861 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3639 3640 +1
Misses 221 221
Partials 0 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where header components wouldn’t be notified of a content offset change when they appear. Body & overlay components already had this intended behavior.
The fix is to merge the “component will appear” logic into a single method, to make sure that all components are treated the same in this regard.