This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Swift: Defer request storage until execution#202
Merged
dflems merged 1 commit intospotify:masterfrom Jan 23, 2021
kmcbride:swift-request-management
Merged
Swift: Defer request storage until execution#202dflems merged 1 commit intospotify:masterfrom kmcbride:swift-request-management
dflems merged 1 commit intospotify:masterfrom
kmcbride:swift-request-management
Conversation
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 94.87% 94.80% -0.08%
==========================================
Files 24 24
Lines 1229 1231 +2
==========================================
+ Hits 1166 1167 +1
- Misses 63 64 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dflems
approved these changes
Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small optimization to prevent rare cases where objects linger in memory when the API user creates a request without executing it. Request removal should now always occur because they will only be added if a
performis attempted — which ultimately leads to a response handler removing the stored request.