Set libtool Build Setting for excluded sdks#198
Merged
polac24 merged 5 commits intospotify:masterfrom Apr 15, 2023
Merged
Conversation
polac24
requested review from
CognitiveDisson,
PatrikBillgren,
acbdev and
aleksandergrzyb
aleksandergrzyb
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #190, if LIBTOOL Build setting is set to
"", static library cannot build ObjC files and fails with a cryptic error:This PR sets it to the original
libtoolvalue so for excluded wachOS, it looks like:This workaround is added to the cocoapods and standalone integrations.