Corrections for scatter test#158
Merged
iampelle merged 2 commits intospotify:Release-4.0.2from Mar 30, 2023
Merged
Conversation
iampelle
approved these changes
Mar 30, 2023
iampelle
added a commit
that referenced
this pull request
Mar 30, 2023
* Fixed categorical_order_by used with array_like (#157) * Fix categorical_order_by check for scatter plot * Fix categorical_order_by check for _construct_source * Refactor category sorting in _construct_source * Add tests for categorical_order_by * Correct scatter test (#158) * Update version in init * Update HISTORY.rst --------- Co-authored-by: Quoc Duong Bui <35042166+vanHekthor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
TestScatter.test_single_numeric_scattertested the wrong plot methodWhich issue(s) this PR fixes
Fixes #
Special notes for your reviewer:
Release note: