chore: version 0.2.1#8
Merged
Merged
Conversation
fabriziodemaria
added a commit
that referenced
this pull request
May 29, 2026
… instead of blocking
Confidence does have a null/existence check: an attribute criterion with no
inner rule is a presence test (resolver ir_builder.rs existence arm; it appears
in the resolver's own spec fixtures), and the admin API accepts it on create
(epx-flags-admin TargetingValidator does no structural validation for ATTRIBUTE
criteria). Wrapping it in `not` expresses "attribute is null".
So IS_NULL maps directly — emit `{ attribute: { attributeName } }` referenced
under `not` — even when it serves a non-default variant or is ANDed with other
conditions. This removes the previous "drop only if variant == default" trick
and unblocks the combined case.
Genuinely-blocked set narrows to two whole-flag cases: generic regex and
SWITCHBACK.
- shared core: add existence/null criterion form, combinator row, and two worked
examples (IS null, IS null combined)
- Eppo skill: rewrite the IS_NULL section as a direct not(exists) translation,
drop the combined/non-default BLOCKED rows, note the empty-in-editor caveat,
add a "Null rules emitted" plan field
- fixtures: flip #8 to serve a non-default variant for no-plan subjects and #12
(IS_NULL ANDed with plan==free) to migratable; both now exercise the not(exists)
path. verify_migration.py moves null-and-condition to MIGRATED_FLAGS and adds a
no-country/free context; 90 cases pass, 2 blocked.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.