refactor: WASM is default in local provider#255
Closed
fabriziodemaria wants to merge 1 commit intomainfrom
Closed
Conversation
fabriziodemaria
changed the title
vahidlazio
approved these changes
Sep 12, 2025
vahidlazio
reviewed
Sep 12, 2025
| } else { | ||
| } else if (env != null && env.equals("JAVA")) { | ||
| this.flagResolverService = LocalResolverServiceFactory.from(apiSecret, clientSecret, false); | ||
| } else { |
Contributor
There was a problem hiding this comment.
isn't this just equivalent of if not java then have it as
this.flagResolverService = LocalResolverServiceFactory.from(apiSecret, clientSecret, true); and doesn't it mean we have wasm enabled by default even for our current customers?
Member
Author
|
I ended up merging this functionality in #256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step towards, eventually, removing the Java local provider