Fix table name returned for CASTed columns#352
Merged
labianchin merged 3 commits intospotify:masterfrom Aug 2, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
============================================
+ Coverage 90.08% 90.34% +0.25%
- Complexity 230 233 +3
============================================
Files 25 25
Lines 908 911 +3
Branches 65 67 +2
============================================
+ Hits 818 823 +5
+ Misses 59 58 -1
+ Partials 31 30 -1 |
Contributor
Author
labianchin
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported by an internal user, when
--sqlFileparameter is used and one of the columns is CASTeddbeam throws an exception
It turned out that ResultSetMetaData.getTableName(...) returns an empty string for CASTed columns (on Postgres), which is not accepted later by
org.apache.avro.Schema.Changes
The change is to either return non-empty value or default one.
Tests:
Checklist for PR author(s)
mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)