Skip to content

Add --minRows parameter#375

Merged
labianchin merged 1 commit intomasterfrom
min_rows
Aug 31, 2021
Merged

Add --minRows parameter#375
labianchin merged 1 commit intomasterfrom
min_rows

Conversation

@labianchin
Copy link
Collaborator

Introduce --minRows parameters. It can be used to check and fail the job if the the output contain too few records.

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %) and/or integration tests.
  • Ensure code formating (use mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)
  • Document any relevant additions/changes in the appropriate spot in javadocs/docs/README.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #375 (ef13d12) into master (b90b31b) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #375      +/-   ##
============================================
+ Coverage     90.86%   91.01%   +0.14%     
- Complexity      237      240       +3     
============================================
  Files            25       26       +1     
  Lines           909      924      +15     
  Branches         66       67       +1     
============================================
+ Hits            826      841      +15     
  Misses           54       54              
  Partials         29       29              

@labianchin labianchin merged commit da7f5ed into master Aug 31, 2021
@labianchin labianchin deleted the min_rows branch August 31, 2021 07:14
@rulle-io
Copy link
Contributor

Nice feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants