Conversation
Including taking care of some incompatible API changes. Nothing visible in the Folsom API though.
protocol7
force-pushed
the
ngn/bump-dependencies
branch
from
8e835f5 to
170275a
Compare
|
LGTM |
mbruggmann
approved these changes
Aug 5, 2019
| ForkJoinPool.defaultForkJoinWorkerThreadFactory, | ||
| new UncaughtExceptionHandler(), | ||
| true)) | ||
| ::get; |
Member
There was a problem hiding this comment.
Guess we could type the Supplier field and constants as the Guava one to avoid the ::get calls here but I'm not sure if that's better.
Contributor
Author
There was a problem hiding this comment.
Yeah, I was considering the same. But in general I'd like to lessen our use of Guava in Folsom, and that would be a step in the wrong direction. I was also considering adding a local memoize function instead, using only java.util.function.Supplier, but decided to rather do so in a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.