added transcoder for serializable objects#39
Conversation
1 similar comment
There was a problem hiding this comment.
I don't understand the last part of this method name - typo?
There was a problem hiding this comment.
Oops sorry, definitely a typo
|
I like the idea in general, just needs some fixes before we can merge. |
There was a problem hiding this comment.
Good catch! Though I guess it doesn't matter since we don't need a consistent serial id for a very short lived test class/object.
|
Made all the suggested changes. Im not sure why the ci is failing as I didnt touch that code. |
|
The tests were not very robust - I think I fixed that in master though. So let's just ignore the report here. Everything looks good to me! Feel free to merge. |
|
I dont think I was ever added to the Spotify organization so I do not have permissions to merge. |
|
A good thing I'm lurking here, then. You should have an invite. |
added transcoder for serializable objects
|
Do you have an ETA for a release with that feature? |
|
Not really, but if you just want this feature you can easily add it manually in your project for now, it's a very small amount of code (and you can look at this PR for inspiration). |
|
True :) |
Caching serializable objects is an extremely common use case and is the easiest way to use memcached and folsom out of the box.