Use dns-java 3.0 which adds support for dns ttl#50
Merged
Conversation
Contributor
|
+1 |
Contributor
There was a problem hiding this comment.
Seems we'd wait 1 hour before attempting to resolve again if there was no records found. That'll happen from time to time in prod due to infra breakage.
How about a special case where we retry earlier when no records were found?
Member
Author
There was a problem hiding this comment.
True, didn't think about that case. Maybe we should keep the old setting then, but have it be treated as either the max value or the default if there are no hosts found.
Member
Author
There was a problem hiding this comment.
fixed now with a force push.
Contributor
|
👍 |
spkrka
added a commit
that referenced
this pull request
Apr 13, 2015
Use dns-java 3.0 which adds support for dns ttl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the option of setting dns refresh period
manually.