Adds BATCH_RUNNING to the visualiser#1817
Merged
Tarrasch merged 1 commit intospotify:masterfrom Aug 22, 2016
Merged
Conversation
In the earlier batching PR, I left out any visualiser elements. This adds BATCH_RUNNING to the Task List selectors and Dependency Graph legend. The legend needed to be widened a bit to accomodate the longer name, and I replace commas with spaces while capitalizing the first letter of each word in the legend.
|
@daveFNbuck, thanks for your PR! By analyzing the annotation information on this pull request, we identified @streetdaddy, @DAVW and @riga to be potential reviewers |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the earlier batching PR, I left out any visualiser elements. This
adds BATCH_RUNNING to the Task List selectors and Dependency Graph
legend. The legend needed to be widened a bit to accomodate the longer
name, and I replace commas with spaces while capitalizing the first
letter of each word in the legend.
Motivation and Context
I realized while working to merge the latest trunk with my fork that my visualizer code was left out.
Have you tested this? If so, how?
I've been using this for a few months now with the batch running backend from the dropped PR. This part should be the same, as it's just about the statuses.