Merged
Conversation
…ummary :recursive:
hirosassa
commented
Feb 22, 2026
Comment on lines
-100
to
-101
| "Sphinx>=1.4.4,<2.0", | ||
| "sphinx_rtd_theme", |
Contributor
Author
There was a problem hiding this comment.
support only Python 3.12 for building docs
dlstadther
reviewed
Feb 22, 2026
Collaborator
dlstadther
left a comment
dlstadther
left a comment
There was a problem hiding this comment.
tests are failing + small comment
tox.ini
Outdated
| [testenv:docs] | ||
| # need Python 3.10 | ||
| basepython = py310 | ||
| # Python 3.12 required for Sphinx 9.x |
Collaborator
There was a problem hiding this comment.
now that 3.13 support was added, feel free to bump this for 313
dlstadther
approved these changes
Feb 23, 2026
Collaborator
dlstadther
left a comment
dlstadther
left a comment
There was a problem hiding this comment.
I'm only unsure of the RTD build. But we can't be 100% sure of that until it's merged and deployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SSIA
Motivation and Context
to follow latest sphinx package
Have you tested this? If so, how?
CI ran successfully