Removed the RemoteSchedulerResponder class#670
Merged
Conversation
Contributor
Author
|
Haha looks like Landscape is now complaining about server.py instead (for all the "unused" kwargs). Well, at least we removed 40 lines. The reason we need kwargs there is that otherwise you can't upgrade the workers independently of the server. Would be good to factor out a proper API at some point. But I don't think RemoteSchedulerResponder was the right approach. |
erikbern
force-pushed
the
erikbern/rpc-cleanup
branch
from
89d9bb3 to
347306a
Compare
erikbern
force-pushed
the
erikbern/rpc-cleanup
branch
from
347306a to
ace47a3
Compare
Contributor
|
LGTM |
erikbern
pushed a commit
that referenced
this pull request
Jan 27, 2015
Removed the RemoteSchedulerResponder class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Landscape went nuts about rpc.py and the existance of
RemoteSchedulerResponderalways bothered the hell out of me – decided to kill it once and for all