make included scopes configurable#26
Merged
pettermahlen merged 3 commits intospotify:masterfrom Sep 16, 2015
Merged
Conversation
Generally, it seems like 'provided' scope shouldn't be included in checks. This change excludes that by default, and allows configuring it
Member
There was a problem hiding this comment.
the defaultValue value seems to conflict with the comment above - is the comment outdated or does the defaultValue part not work?
Member
|
👍 |
Conflicts: maven-plugin/src/main/java/com/spotify/missinglink/maven/CheckMojo.java
pettermahlen
force-pushed
the
configurable-scope-selection
branch
from
3438217 to
8247fa1
Compare
pettermahlen
added a commit
that referenced
this pull request
Sep 16, 2015
make included scopes configurable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally, it seems like 'provided' scope shouldn't be included in checks.
This change excludes that by default, and allows configuring it