Skip to content

Conversation

@volodymyrpavlenko
Copy link

@volodymyrpavlenko volodymyrpavlenko commented Feb 24, 2021

This fixes a bug, where sec-since-oldest-xact-start is only reported for one largest transaction per monitored postgresql instance. This can lead to a situation, where spurious databases appear in metrics, and not more than 1 database is reported at every iteration.

We would like to add database comparison name with the currently connected database. Since postgresql connects to every monitored database separately, this will effectively output sec-since-oldest-xact-start metrics per connected database.

@volodymyrpavlenko volodymyrpavlenko force-pushed the get_oldest_transaction_timestamp_per_database branch from 4c17555 to 5bb8169 Compare February 25, 2021 09:07
Copy link
Contributor

@andreasscherman andreasscherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dflemstr dflemstr merged commit dc04eaf into spotify:master Feb 25, 2021
@volodymyrpavlenko volodymyrpavlenko deleted the get_oldest_transaction_timestamp_per_database branch February 25, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants