Save token after successful authentication when an ClientTokenServices is provided.

[KeesKoffeman]

Fixes gh-498

In addition to this it would be nice if ClientTokenServices is injected by auto-configuration (even when null) to avoid customization of both the filter and the rest template.

[dsyer]

Thanks. Did you fill out the contributor's agreement (link in README)?

[KeesKoffeman]

I did right after I filed the pull request. I selected 'spring-security' and named you as project lead; is that correct?

[dsyer]

That's fine. It's an automated system but I don't always get the notifications.

[Artgit]

When this feature will be available ? Also, is it safe to store token based only on authentication.getName(), resource.getClientId() and resource.getScope as implemented in DefaultClientKeyGenerator.extractKey method ?

I think there is a very good chance to face a collisions between OAuth2 providers in oauth_client_token table.

What do you think ?

[dsyer]

I think you have some very unusual providers if they have identical client id and scope names.

[Artgit]

For example in my current implementation authentication.getName() returns null. This way I think I'll have the only one record (authentication_id will be based for many users only on the same client_id and same scopes) in oauth_client_token table for different users

[dsyer]

Your Authentication is broken then, I guess. If you need to support null names then you should provide your own ClientKeyGenerator.

[Artgit]

Yeah.. I see it now.. According to UserDetails.getUsername() method contract it can't return null.. Right now struggling with a following question http://stackoverflow.com/questions/34920743/spring-security-userdetails-and-username

[pivotal-issuemaster]

@KeesKoffeman Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[kvandake]

Hello. What status it pull request? When will these changes committed?

[pivotal-issuemaster]

@KeesKoffeman Thank you for signing the Contributor License Agreement!

[bvulaj]

I've resyncd the PR and it looks like besides the conflict that this should be all set. Any chance of a merge soon?

[jgrandja]

@bvulaj With the addition of setClientTokenServices(ClientTokenServices) on the Filter, this could only get into the next minor release which would be 2.4. We haven't scheduled 2.4 as of yet and it likely won't be released for a couple months at least.

[jgrandja]

@KeesKoffeman As you may be aware, this project is scheduled to reach EOL. Please see the announcement for further details.

I'm going to close this PR as it doesn't make sense to merge these changes given the status of the project.