Fixes gh-1009 #1010
Fixes gh-1009 #1010
Conversation
Implement client specific LoadBalancedRetryFactory
|
@Ferioney - thanks for submitting this. Will review on Monday. |
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
@Ferioney thanks for submitting the PR. Please see the comment I've added and adjust the PR.
|
|
||
| @Override | ||
| public LoadBalancedRetryPolicy createRetryPolicy(String service, ServiceInstanceChooser serviceInstanceChooser) { | ||
| final LoadBalancerProperties properties = clientLoadBalancerProperties.getClientLoadBalancerProperties(service) |
There was a problem hiding this comment.
@Ferioney , as discussed here, we will wait with resolving properties per client in general till the feature is implemented in Boot, so the changes in this class should be removed. Specifcally, the issue here is that either all properties are resolved "per client" for a given client or none, while in the final version, we would want it to be possible to make that distinction on property level. For now, a simpler implementation only for the specific properties can be added to fix this issue, similarly to what is being done here and here.
|
Closing in favour of #1028 |
3 participants
Implement client specific LoadBalancedRetryFactory