Adds config per load balancer client. #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client specific configuration goes under `spring.cloud.loadbalancer.clients.<serviceId>.*`. Defaults are set using `spring.cloud.loadbalancer.*`. Fixes gh-914
Adds LoadBalancerDefaultMappingsProviderAutoConfiguration to supply the loadbalancer defaults mapping to DefaultsBindHandlerAdvisor
spencergibb
commented
Oct 22, 2021
...mmons/src/main/java/org/springframework/cloud/commons/config/DefaultsBindHandlerAdvisor.java
Show resolved
Hide resolved
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
This all looks very good and solves the default fallback issue. I'm only wandering about if we could also somehow rewrite the places where we use @ConditionalOnProperty (like here) to enable per-client config. wdyt?
| Map<ConfigurationPropertyName, ConfigurationPropertyName> mappings = new HashMap<>(); | ||
| mappings.put(ConfigurationPropertyName.of("spring.cloud.loadbalancer.clients"), | ||
| ConfigurationPropertyName.of("spring.cloud.loadbalancer")); | ||
| return mappings; |
Collaborator
There was a problem hiding this comment.
👍 Looks like that's what we were missing in the previous considerations for this issue.
| public class LoadBalancerDefaultMappingsProviderAutoConfiguration { | ||
|
|
||
| @Bean | ||
| public DefaultsBindHandlerAdvisor.MappingsProvider rabbitExtendedPropertiesDefaultMappingsProvider() { |
Collaborator
There was a problem hiding this comment.
Remove rabbit from method name?
Member
Author
|
yes, anything in LoadBalancerClientConfiguration's will need a custom |
LoadBalancerClientsProperties now extends LoadBalancerProperties. The `clients` attribute is now a field. The `@ConfigurationProperties("spring.cloud.loadbalancer")` has moved from LoadBalancerProperties to LoadBalancerClientsProperties
Closed
|
Thank you! That was a long-awaited feature ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client specific configuration goes under
spring.cloud.loadbalancer.clients.<serviceId>.*. Defaults are set usingspring.cloud.loadbalancer.*.Fixes gh-914