Support to PKCS12 keystores through encryption.keyStore.type property #954
Conversation
| * The KeyStore type (key store file extension used as default). | ||
| */ | ||
| private String type = "jks"; | ||
| private String type; |
There was a problem hiding this comment.
Why did you remove the default value?
There was a problem hiding this comment.
Currently this property is not used in TextEncryptorUtils.createTextEncryptor and the default behaviour is to infer the keystore type from the file extension.
Removing the default value this behaviour is preserved, avoiding a breaking change for who is using, for example, encryption.key-store.location=classpath:test.jceks with no encryption.key-store.type set.
However, while writing this comment, I noticed a default value is expected here:
https://github.com/spring-cloud/spring-cloud-config/blob/e645c802157caa88a8ed50ecb9067335f0c7522f/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/config/EncryptionAutoConfiguration.java#L104
What do you suggest?
There was a problem hiding this comment.
Could you enable your added code below only if it is not the default value?
There was a problem hiding this comment.
I think it's better to rollback to default value. The current behaviour (infer type from extension) is not documented anywhere and the error in case of keystore type mismatch is pretty clear.
|
Sorry, I made a mess with this PR. I opened a new one: |
3 participants
fixes gh-953