Add logic to be more specific about when mark a property source to be profile specific#2437
Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom Jul 4, 2024
Merged
Conversation
… profile specific Fixes spring-cloud#2417
spencergibb
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2417
The problem here two fold.
The profile name (def) is a partial match to the -default in the property source name so we add the Option marking the property source as profile specific. This effects the way Boot orders the property source since profile specific property sources should be ranked higher.
The overrides property source is never marked profile specific and IMO it should always be ranked profile specific so it it always ranked higher.
The logic in the PR is not perfect but honestly it can't be until we add this functionality #2291