docs: Fix global CORS configuration property path#4118
Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom Mar 31, 2026
Merged
docs: Fix global CORS configuration property path#4118ryanjbaxter merged 1 commit intospring-cloud:mainfrom
ryanjbaxter merged 1 commit intospring-cloud:mainfrom
Conversation
ryanjbaxter
requested changes
Mar 30, 2026
| The JSONToGRPC GatewayFilter Factory converts a JSON payload to a gRPC request. | ||
|
|
||
| [[jsontogrpc-dependencies]] | ||
| == Required Dependencies |
Contributor
There was a problem hiding this comment.
This does not seem relevant to the issue
Contributor
Author
The globalcors configuration properties were documented under the old path spring.cloud.gateway.globalcors, but were moved to spring.cloud.gateway.server.webflux.globalcors in a prior refactor. Updated both the YAML example and the inline property reference in the prose to use the correct path. Fixes spring-cloudgh-4103 Signed-off-by: Tarte <emprimula@gmail.com>
bd99e26 to
3f520cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The global CORS configuration documentation uses the old property path:
But since commit eca63cb, the correct path is:
This is confirmed by
GlobalCorsPropertiesusingGatewayProperties.PREFIX + ".globalcors", wherePREFIX = "spring.cloud.gateway.server.webflux".Closes #4103
Changes
add-to-simple-url-handler-mapping