Skip to content

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Apr 30, 2023

No description provided.

wind57 and others added 30 commits December 4, 2021 07:59
wind57 added 21 commits April 6, 2023 08:13
and having Spring Cloud Kubernetes read them from the file system.
This behavior is controlled by the `spring.cloud.kubernetes.config.paths` property. You can use it in
addition to or instead of the mechanism described earlier.
You can specify multiple (exact) file paths in `spring.cloud.kubernetes.config.paths` by using the `,` delimiter.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is in this sentence:

You can specify multiple (exact) file paths in spring.cloud.kubernetes.config.paths by using the , delimiter.

It was probably left in the documentation from an older implementation, because right now, this is expected to be a List<String>:

@ConfigurationProperties(ConfigMapConfigProperties.PREFIX)
public record ConfigMapConfigProperties(....@DefaultValue List<String> paths, ...

You can look in ConfigMapPropertySourceLocator::addPropertySourcesFromPaths also, if needed.

@wind57 wind57 marked this pull request as ready for review April 30, 2023 19:54
@wind57
Copy link
Contributor Author

wind57 commented Apr 30, 2023

@ryanjbaxter minor thing that resulted of a bug investigation

@ryanjbaxter ryanjbaxter added this to the 3.0.3 milestone May 1, 2023
@ryanjbaxter ryanjbaxter merged commit 7f08df4 into spring-cloud:main May 1, 2023
@wind57 wind57 deleted the fix-paths-documentation branch May 1, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants