Support Spring formatting annotations for params #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ConversionService and passes annotations (through TypeDescriptor) - ConversionService can now pick up @DateTimeFormat and @numberformat and convert the params applying those.
…for the element type when param is Iterable.
grelland
commented
Jul 26, 2018
| } | ||
| } | ||
|
|
||
| // TODO Can this go? Doesn't seem to be referenced anymore (but is public). |
Contributor
There was a problem hiding this comment.
We have to keep it now. You can add a @Deprecated annotation and we can remove it in the next major release
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
============================================
- Coverage 76.24% 75.87% -0.38%
Complexity 283 283
============================================
Files 36 36
Lines 1183 1206 +23
Branches 183 186 +3
============================================
+ Hits 902 915 +13
- Misses 204 212 +8
- Partials 77 79 +2
|
ryanjbaxter
changed the title
ryanjbaxter
approved these changes
Jul 30, 2018
| } | ||
| } | ||
|
|
||
| // TODO Can this go? Doesn't seem to be referenced anymore (but is public). |
Contributor
There was a problem hiding this comment.
We have to keep it now. You can add a @Deprecated annotation and we can remove it in the next major release
grelland
force-pushed
the
support-formatting-annotations
branch
from
d969d7b to
574cb0d
Compare
grelland
force-pushed
the
support-formatting-annotations
branch
from
574cb0d to
ffb223a
Compare
spencergibb
approved these changes
Jul 30, 2018
Contributor
Author
|
What's the status on merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-47