Skip to content

Conversation

@ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Dec 12, 2018

Obvious Fix

@pivotal-issuemaster
Copy link

@ackintosh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@ackintosh This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #1157 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1157      +/-   ##
============================================
- Coverage     69.74%   69.62%   -0.12%     
  Complexity      724      724              
============================================
  Files           133      133              
  Lines          3368     3368              
  Branches        364      364              
============================================
- Hits           2349     2345       -4     
- Misses          811      816       +5     
+ Partials        208      207       -1
Impacted Files Coverage Δ Complexity Δ
...ing/TracingConnectionFactoryBeanPostProcessor.java 69.64% <0%> (-3.58%) 6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c426a...4444cd7. Read the comment docs.

Copy link
Contributor

@devinsba devinsba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have merge power so I can't merge it.

Thanks for the fixes though!

@marcingrzejszczak
Copy link
Contributor

Can you fix it in the docs module, not the root README.

@ackintosh
Copy link
Contributor Author

Thanks for pointing it out. I'll fix it.

@ackintosh
Copy link
Contributor Author

@marcingrzejszczak I've fixed it. Please have a look when you have time. 😌

@marcingrzejszczak marcingrzejszczak added this to the 2.1.0.RC2 milestone Dec 15, 2018
@marcingrzejszczak marcingrzejszczak merged commit d4c4a88 into spring-cloud:master Dec 15, 2018
@marcingrzejszczak
Copy link
Contributor

Congrats @ackintosh on your first contribution!!

@ackintosh
Copy link
Contributor Author

Wow! You made my day. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants