Skip to content

Fix typo in docs #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2018
Merged

Fix typo in docs #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a92a5f8
Fix typo
ackintosh Dec 12, 2018
1c4eae0
Revert the change applied to root README
ackintosh Dec 13, 2018
63173ef
Fix the docs module
ackintosh Dec 13, 2018
4444cd7
Revert a change of root README
ackintosh Dec 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/src/main/asciidoc/intro.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ The following example shows setting baggage on a span:
[source,java]
----
include::{github-raw}/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/multiple/MultipleHopsIntegrationTests.java[tags=baggage,indent=0]
}
----

===== Baggage versus Span Tags
Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/spring-cloud-sleuth.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ IMPORTANT: Remember that adding entries to MDC can drastically decrease the perf
The `TraceContext.Extractor<C>` reads trace identifiers and sampling status from an incoming request or message.
The carrier is usually a request object or headers.

This utility is used in standard instrumentation (such as `HttpServerHandler``) but can also be used for custom RPC or messaging code.
This utility is used in standard instrumentation (such as `HttpServerHandler`) but can also be used for custom RPC or messaging code.

`TraceContextOrSamplingFlags` is usually used only with `Tracer.nextSpan(extracted)`, unless you are
sharing span IDs between a client and a server.
Expand Down