upgrade dependencies and refactor code #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'd like to request that you please keep the linter enabled on this project. As soon as it is turned off, the code style starts to drift and it makes it a lot more difficult to sync changes from other projects. |
Contributor
Author
|
Note that there are some dependencies which cannot be upgraded yet, mostly eslint and stylelint. There were a lot of breaking changes in these projects, so trying to get them all upgrade and synchronized is a very difficult task. |
- upgrade UI preview to Asciidoctor.js 2 - upgrade build dependencies - reenable lint task - fix code style violations - add docsearch.js package; retrieve docsearch style and script from package - rewrite docsearch integration to be self-contained script - move custom docsearch styles into vendored file - put favicon and docsearch link in correct partials - remove relativize UI helper
mojavelinux
force-pushed
the
upgrade-deps-and-refactor
branch
from
51e7d47 to
60c6b8f
Compare
rwinch
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lays the groundwork for integrating Asciidoctor Tabs and improving the search. I have confirmed through testing and visual inspection that this PR does not introduce any functional changes. This is purely a refactoring of the code both to update the dependencies and to bring in inline with the UI template project.