enhance the search widget #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mojavelinux
commented
Dec 21, 2022
mojavelinux
commented
- add filter by current version
- add pagination
- enclose the search query in a field
- add keyboard navigation
- restore search on back
- simplify styles
Contributor
Author
|
These changes are essential for supporting the search version filter. The styles have also been substantially simplified. The functionality now closely matches that of docs.asciidoctor.org. |
- add filter by current version - add pagination - enclose the search query in a field - add keyboard navigation - restore search on back - simplify styles
mojavelinux
force-pushed
the
enhance-search
branch
from
2c0d32d to
7ddcb38
Compare
rwinch
approved these changes
Jan 11, 2023
Collaborator
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks @mojavelinux Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.