Record JVM version change reasons#1795
Open
YangSiJun528 wants to merge 4 commits into
Open
Conversation
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
Add test-only setup to verify Java 1.8 with Web is upgraded to Java 17 and documented in HELP.md. Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
This reverts commit f2e0341. Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: sijun-yang <yangsijun5528@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for recording why a project's JVM version was changed during project generation.
Changes
JvmVersionChangeReason, an interface that exposes a reason id.MutableProjectDescription#changeJvmVersionto update the JVM version and record a reason when it changes.ProjectDescription.Notes
This change only records JVM version change reasons in Initializr. Consumers such as start.spring.io can define their own reason ids and decide how to render them in generated documentation.
If this PR is merged, I would be interested in helping with the corresponding start.spring.io changes.
Closes gh-1742