-
Notifications
You must be signed in to change notification settings - Fork 962
Upgrade to Spring AI 1.0.0-M8 #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ilayaperumal Gopinathan <151690+ilayaperumalg@users.noreply.github.com>
| mappings: | ||
| - compatibilityRange: "[3.4.0,3.5.0-M1)" | ||
| version: 1.0.0-M7 | ||
| - compatibilityRange: "[3.4.0,3.5.0-M3)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this. Spring Boot is at 3.5.0-RC1 at the moment so you won't gain anything by changing the range mid-flight like this.
What are you trying to convey? Is Spring AI M8 compatible with Spring Boot 3.5 or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Spring AI M8 was tested against Spring Boot 3.5.0-M3 and hence we updated the range. Perhaps this should be 3.5.0-RC1 to include the support for 3.5.0-M3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that's also inaccurate as the closing parenthesis is exclusive. So it would have offered M8 up to 3.5.0-M2.
I understand that m8 works with spring boot 3.5 and m7 wasn't tested. Is it supposed to be offered for spring boot 3.4 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks for clarifying. yes, It is supposed to support Spring Boot 3.4 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Stephane and I am currently running the tests against Spring Boot 3.5.0-RC1. With that, we can update the range accordingly.
See gh-1789 Signed-off-by: Ilayaperumal Gopinathan <151690+ilayaperumalg@users.noreply.github.com>
No description provided.