Skip to content

Conversation

@ilayaperumalg
Copy link
Contributor

No description provided.

Signed-off-by: Ilayaperumal Gopinathan <151690+ilayaperumalg@users.noreply.github.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 30, 2025
@snicoll snicoll changed the title Update Spring AI 1.0.0-M8 Upgrade to Spring AI 1.0.0-M8 May 1, 2025
mappings:
- compatibilityRange: "[3.4.0,3.5.0-M1)"
version: 1.0.0-M7
- compatibilityRange: "[3.4.0,3.5.0-M3)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this. Spring Boot is at 3.5.0-RC1 at the moment so you won't gain anything by changing the range mid-flight like this.

What are you trying to convey? Is Spring AI M8 compatible with Spring Boot 3.5 or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Spring AI M8 was tested against Spring Boot 3.5.0-M3 and hence we updated the range. Perhaps this should be 3.5.0-RC1 to include the support for 3.5.0-M3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that's also inaccurate as the closing parenthesis is exclusive. So it would have offered M8 up to 3.5.0-M2.

I understand that m8 works with spring boot 3.5 and m7 wasn't tested. Is it supposed to be offered for spring boot 3.4 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks for clarifying. yes, It is supposed to support Spring Boot 3.4 as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Stephane and I am currently running the tests against Spring Boot 3.5.0-RC1. With that, we can update the range accordingly.

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue type: entry-upgrade and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels May 1, 2025
snicoll pushed a commit that referenced this pull request May 1, 2025
See gh-1789

Signed-off-by: Ilayaperumal Gopinathan <151690+ilayaperumalg@users.noreply.github.com>
snicoll added a commit that referenced this pull request May 1, 2025
@snicoll snicoll closed this in 59721ce May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants