Skip to content

Review doFinally block in observability for chat models. #1502

@markpollack

Description

@markpollack

Removing the following 'TODO' comment in public Flux<ChatResponse> stream(Prompt prompt) for various models.

.doOnError(observation::error)
				.doFinally(s -> {
					// TODO: Consider a custom ObservationContext and
					// include additional metadata
					// if (s == SignalType.CANCEL) {
					// observationContext.setAborted(true);
					// }
					observation.stop();
				})

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions