Skip to content

Fix flaky tests in PostgresMlEmbeddingModelIT #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix flaky tests in PostgresMlEmbeddingModelIT #1610

wants to merge 1 commit into from

Conversation

@making
Copy link
Member

@making making commented Oct 28, 2024

This PR removes creating unnecessary hstore postgres extension in PostgresMlEmbeddingModel that caused flaky tests.

Now all tests pass

image

@making making mentioned this pull request Oct 28, 2024
Closed
@markpollack markpollack self-assigned this Oct 28, 2024
@markpollack markpollack added this to the 1.0.0-M4 milestone Oct 28, 2024
@markpollack
Copy link
Member

markpollack commented Oct 28, 2024

Thanks! merged in f3c32df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@markpollack markpollack

Labels

postgresml

Projects

None yet

Milestone

1.0.0-M4

Development

Successfully merging this pull request may close these issues.

2 participants

@making @markpollack