Added index of tool call in the list of tool calls #2084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricken Bazolo <ricken.bazolo@gmail.com>
tzolov
reviewed
Feb 11, 2025
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.UUID; | ||
| import java.util.*; |
There was a problem hiding this comment.
Wildcard imports are not allowed.
Will try to fix it while reviewing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix :
org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Unrecognized field "index" (class org.springframework.ai.mistralai.api.MistralAiApi$ChatCompletionMessage$ToolCall), not marked as ignorableMistral has added an extra field named
indexintool_callsresponses, which causes an exception when mapping the template response.This pull request corrects this problem. Currently, this
indexfield is not used by Spring AI.However, in view of developments in assistant response models, wouldn't it be preferable to modify the
AssistantMessagestructure to make it generic and more adaptable ? @tzolov