Skip to content

Fix issue with CosmosDBVectorStore.Builder - "... must not be empty" #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Fix issue with CosmosDBVectorStore.Builder - "... must not be empty" #2260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...framework/ai/autoconfigure/vectorstore/cosmosdb/CosmosDBVectorStoreAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public CosmosDBVectorStore cosmosDBVectorStore(ObservationRegistry observationRe
.metadataFields(List.of(properties.getMetadataFields()))
.vectorStoreThroughput(properties.getVectorStoreThroughput())
.vectorDimensions(properties.getVectorDimensions())
.partitionKeyPath(properties.getPartitionKeyPath())
.build();

}
Expand Down
10 changes: 5 additions & 5 deletions ...-store/src/main/java/org/springframework/ai/vectorstore/cosmosdb/CosmosDBVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ private Builder(CosmosAsyncClient cosmosClient, EmbeddingModel embeddingModel) {
* @throws IllegalArgumentException if containerName is null or empty
*/
public Builder containerName(String containerName) {
Assert.hasText(this.containerName, "Container name must not be empty");
Assert.hasText(containerName, "Container name must not be empty");
this.containerName = containerName;
return this;
}
Expand All @@ -428,7 +428,7 @@ public Builder containerName(String containerName) {
* @throws IllegalArgumentException if databaseName is null or empty
*/
public Builder databaseName(String databaseName) {
Assert.hasText(this.databaseName, "Database name must not be empty");
Assert.hasText(databaseName, "Database name must not be empty");
this.databaseName = databaseName;
return this;
}
Expand All @@ -440,7 +440,7 @@ public Builder databaseName(String databaseName) {
* @throws IllegalArgumentException if partitionKeyPath is null or empty
*/
public Builder partitionKeyPath(String partitionKeyPath) {
Assert.hasText(this.partitionKeyPath, "Partition key path must not be empty");
Assert.hasText(partitionKeyPath, "Partition key path must not be empty");
this.partitionKeyPath = partitionKeyPath;
return this;
}
Expand All @@ -452,7 +452,7 @@ public Builder partitionKeyPath(String partitionKeyPath) {
* @throws IllegalArgumentException if vectorStoreThroughput is not positive
*/
public Builder vectorStoreThroughput(int vectorStoreThroughput) {
Assert.isTrue(this.vectorStoreThroughput > 0, "Vector store throughput must be positive");
Assert.isTrue(vectorStoreThroughput > 0, "Vector store throughput must be positive");
this.vectorStoreThroughput = vectorStoreThroughput;
return this;
}
Expand All @@ -464,7 +464,7 @@ public Builder vectorStoreThroughput(int vectorStoreThroughput) {
* @throws IllegalArgumentException if vectorDimensions is not positive
*/
public Builder vectorDimensions(long vectorDimensions) {
Assert.isTrue(this.vectorDimensions > 0, "Vector dimensions must be positive");
Assert.isTrue(vectorDimensions > 0, "Vector dimensions must be positive");
this.vectorDimensions = vectorDimensions;
return this;
}
Expand Down