Skip to content

Conversation

@HyunSangHan
Copy link
Contributor

@HyunSangHan HyunSangHan commented May 11, 2025

spring.ai.vertex.ai.gemini.chat.options.* were not configured to support auto-completion in configuration files.

After adding this annotation, building the project triggers the Spring Boot configuration metadata processor to handle the @NestedConfigurationProperty annotation and generate the necessary metadata for auto-completion.

I tested this locally, and I was able to confirm that the generated metadata file includes the spring.ai.vertex.ai.gemini.chat.options.* properties.

Closes #3079

Comment on lines 39 to 40
*
* @author Hyunsang Han
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*
* @author Hyunsang Han

Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the @author tag to the class level.

  * @author Christian Tzolov
  * @author Hyunsang Han
  * @since 0.8.0
  */
@ConfigurationProperties(VertexAiGeminiChatProperties.CONFIG_PREFIX)
public class VertexAiGeminiChatProperties {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed it. Thanks!

/**
* Vertex AI Gemini API generative options.
*
* @author Hyunsang Han
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @author tag should be used on the class itself instead of the specific method. Could you move this there (line 28)? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

Signed-off-by: Hyunsang Han <gustkd3@snu.ac.kr>
@ilayaperumalg ilayaperumalg self-assigned this May 12, 2025
@ilayaperumalg ilayaperumalg added this to the 1.0.0-RC1 milestone May 12, 2025
@ilayaperumalg
Copy link
Member

@HyunSangHan Thanks for the PR!

@ilayaperumalg ilayaperumalg merged commit 49209d1 into spring-projects:main May 12, 2025
2 checks passed
namsoo2 pushed a commit to namsoo2/spring-ai that referenced this pull request Jun 9, 2025
…pring-projects#3101)

Signed-off-by: Hyunsang Han <gustkd3@snu.ac.kr>
Signed-off-by: minsoo.nam <minsoo.nam@linecorp.com>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spring.ai.vertex.ai.gemini.chat.options.model doesn’t auto complete

4 participants