-
Notifications
You must be signed in to change notification settings - Fork 2k
Enable auto complete for 'spring.ai.vertex.ai.gemini.chat.options' #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * | ||
| * @author Hyunsang Han |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * | |
| * @author Hyunsang Han |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the @author tag to the class level.
* @author Christian Tzolov
* @author Hyunsang Han
* @since 0.8.0
*/
@ConfigurationProperties(VertexAiGeminiChatProperties.CONFIG_PREFIX)
public class VertexAiGeminiChatProperties {There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed it. Thanks!
| /** | ||
| * Vertex AI Gemini API generative options. | ||
| * | ||
| * @author Hyunsang Han |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @author tag should be used on the class itself instead of the specific method. Could you move this there (line 28)? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
Signed-off-by: Hyunsang Han <gustkd3@snu.ac.kr>
|
@HyunSangHan Thanks for the PR! |
…pring-projects#3101) Signed-off-by: Hyunsang Han <gustkd3@snu.ac.kr> Signed-off-by: minsoo.nam <minsoo.nam@linecorp.com>
…pring-projects#3101) Signed-off-by: Hyunsang Han <gustkd3@snu.ac.kr>
spring.ai.vertex.ai.gemini.chat.options.*were not configured to support auto-completion in configuration files.After adding this annotation, building the project triggers the Spring Boot configuration metadata processor to handle the
@NestedConfigurationPropertyannotation and generate the necessary metadata for auto-completion.I tested this locally, and I was able to confirm that the generated metadata file includes the
spring.ai.vertex.ai.gemini.chat.options.*properties.Closes #3079