fix: Improve JSON error handling in MethodToolCallback #5032
+138
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper exception handling for JSON processing failures in tool argument extraction and conversion. Wrap JsonProcessingException in ToolExecutionException to provide better error context when tools receive malformed input. Resolves: spring-projects#3924 spring-projects#4987 spring-projects#3933 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
| return JsonParser.fromJson(toolInput, new TypeReference<>() { | ||
| }); | ||
| } | ||
| catch (IllegalStateException ex) { |
Member
There was a problem hiding this comment.
Instead of checking just the IllegalStateException, we agreed to check all exception which is similar to how MCP toolcallback error handling is done. I will make the change and update the PR.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper exception handling for JSON processing failures in tool argument extraction and conversion. Wrap JsonProcessingException in ToolExecutionException to provide better error context when tools receive malformed input.
Resolves: #3924 #4987 #3933