Skip to content

Ollama: remove invalid embedding_only option #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Ollama: remove invalid embedding_only option #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions models/spring-ai-ollama/src/main/java/org/springframework/ai/ollama/api/OllamaOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,6 @@ public class OllamaOptions implements ChatOptions, EmbeddingOptions {
*/
@JsonProperty("use_mlock") private Boolean useMLock;

/**
* ???
*/
@JsonProperty("embedding_only") private Boolean embeddingOnly;

/**
* ???
*/
Expand Down Expand Up @@ -319,11 +314,6 @@ public OllamaOptions withUseMLock(Boolean useMLock) {
return this;
}

public OllamaOptions withEmbeddingOnly(Boolean embeddingOnly) {
this.embeddingOnly = embeddingOnly;
return this;
}

public OllamaOptions withRopeFrequencyBase(Float ropeFrequencyBase) {
this.ropeFrequencyBase = ropeFrequencyBase;
return this;
Expand Down Expand Up @@ -520,14 +510,6 @@ public void setUseMLock(Boolean useMLock) {
this.useMLock = useMLock;
}

public Boolean getEmbeddingOnly() {
return embeddingOnly;
}

public void setEmbeddingOnly(Boolean embeddingOnly) {
this.embeddingOnly = embeddingOnly;
}

public Float getRopeFrequencyBase() {
return ropeFrequencyBase;
}
Expand Down