Skip to content

test: Add unit test for ToolCallAdvisor#doFinalizeLoop #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guanxuc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Add unit test for ToolCallAdvisor#doFinalizeLoop #5065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...t-chat/src/test/java/org/springframework/ai/chat/client/advisor/ToolCallAdvisorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,8 @@ void testBuilderGetters() {

@Test
void testExtendedAdvisorWithCustomHooks() {
int[] hookCallCounts = { 0, 0, 0 }; // initializeLoop, beforeCall, afterCall
int[] hookCallCounts = { 0, 0, 0, 0 }; // initializeLoop, beforeCall, afterCall,
// doFinalizeLoop

// Create extended advisor to verify hooks are called
TestableToolCallAdvisor advisor = new TestableToolCallAdvisor(this.toolCallingManager,
Expand All @@ -413,11 +414,13 @@ void testExtendedAdvisorWithCustomHooks() {
assertThat(hookCallCounts[0]).isEqualTo(1); // doInitializeLoop called once
assertThat(hookCallCounts[1]).isEqualTo(1); // doBeforeCall called once
assertThat(hookCallCounts[2]).isEqualTo(1); // doAfterCall called once
assertThat(hookCallCounts[3]).isEqualTo(1); // doFinalizeLoop called once
}

@Test
void testExtendedAdvisorHooksCalledMultipleTimesWithToolCalls() {
int[] hookCallCounts = { 0, 0, 0 }; // initializeLoop, beforeCall, afterCall
int[] hookCallCounts = { 0, 0, 0, 0 }; // initializeLoop, beforeCall, afterCall,
// doFinalizeLoop

TestableToolCallAdvisor advisor = new TestableToolCallAdvisor(this.toolCallingManager,
BaseAdvisor.HIGHEST_PRECEDENCE + 300, hookCallCounts);
Expand Down Expand Up @@ -454,6 +457,8 @@ void testExtendedAdvisorHooksCalledMultipleTimesWithToolCalls() {
// iteration)
assertThat(hookCallCounts[2]).isEqualTo(2); // doAfterCall called twice (each
// iteration)
assertThat(hookCallCounts[3]).isEqualTo(1); // doFinalizeLoop called once
// (after loop)
}

@Test
Expand Down Expand Up @@ -606,6 +611,15 @@ protected ChatClientResponse doAfterCall(ChatClientResponse chatClientResponse,
return super.doAfterCall(chatClientResponse, callAdvisorChain);
}

@Override
protected ChatClientResponse doFinalizeLoop(ChatClientResponse chatClientResponse,
CallAdvisorChain callAdvisorChain) {
if (this.hookCallCounts != null) {
this.hookCallCounts[3]++;
}
return super.doFinalizeLoop(chatClientResponse, callAdvisorChain);
}

static TestableBuilder testBuilder() {
return new TestableBuilder();
}
Expand Down