Make ModelRequest#getOptions non-null#5403
Merged
ericbottard merged 1 commit intospring-projects:mainfrom Feb 4, 2026
Merged
Conversation
Before this commit, ModelRequest#getOptions was nullable but almost all usages were expecting mandatory options. So this commit turns it to non-null and adapt usages accordingly, using default/empty options where relevant. Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
sdeleuze
force-pushed
the
non-null-model-options
branch
from
daf5e38 to
ff8b50f
Compare
ericbottard
reviewed
Feb 4, 2026
...i-gemini/src/main/java/org/springframework/ai/vertexai/gemini/VertexAiGeminiChatOptions.java
Show resolved
Hide resolved
sdeleuze
added a commit
to sdeleuze/spring-ai
that referenced
this pull request
Feb 11, 2026
This reverts commit ff8b50f.
sdeleuze
added a commit
to sdeleuze/spring-ai
that referenced
this pull request
Feb 11, 2026
Update DeepSeekChatModel for nullable prompt options. Signed-off-by: Sébastien Deleuze <sdeleuze@users.noreply.github.com>
Contributor
Author
|
Due to various unwanted side effects, this change has been reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit,
ModelRequest#getOptionswas nullable but almost all usages were expecting mandatory options.So this commit turns it to non-null and adapt usages accordingly, using default/empty options where relevant.