Add @Nullable to ChatClientResponse.Builder#context value parameter#5547
Merged
sdeleuze merged 1 commit intospring-projects:mainfrom Mar 6, 2026
Merged
Add @Nullable to ChatClientResponse.Builder#context value parameter#5547sdeleuze merged 1 commit intospring-projects:mainfrom
@Nullable to ChatClientResponse.Builder#context value parameter#5547sdeleuze merged 1 commit intospring-projects:mainfrom
Conversation
…ontext value parameter - Add @nullable to value parameter in context(String key, Object value) - Add test whenBuilderContextWithNullValueThenCreateSuccessfully for null value in builder Fixes spring-projectsGH-5546 Signed-off-by: Chaemin Lee <akak640@gmail.com>
sdeleuze
changed the title
@Nullable to ChatClientResponse.Builder#context value parameter
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
@Nullableto thevalueparameter inChatClientResponse.Builder.context(String key, Object value)for consistency withChatClientRequest.Builder.context(String key, @Nullable Object value)and with the context map typeMap<String, @Nullable Object>.Changes
context(String key, @Nullable Object value)— add@NullabletovaluewhenBuilderContextWithNullValueThenCreateSuccessfully()to verify that the builder accepts null as context valueFixes GH-5546