Remove common ChatOptions setters calls#5957
Merged
sdeleuze merged 2 commits intospring-projects:mainfrom May 7, 2026
Merged
Conversation
This is in preparation of making the options immutable. Change the advisor to return a new prompt with new options rather than modifying the options in place. Adapt tests that used a lot of mocking to use real objects instead, introducing DefaultStructuredOutputChatOptions for that purpose. Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
In preparation of making the options immutable, remove the use of mutating setter in favor of creating a new prompt with new copied options in the advisor. Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
sdeleuze
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this commit, there are no explicit setters being called in production code.
Setters may still be used by tests, and reflectively when options are used as
@ConfigurationProperties